fix: issue with omiting endpoint #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
hello @whyvl, may I know if there is anything left for merging this PR? |
Owner
Mb I just mostly haven't had the time to check the PRs, sorry for the lack of communication |
Contributor
Author
|
thank you! if you could create a new release, that would be awesome because there have been some new changes including this fix :). |
artem-russkikh
added a commit
to artem-russkikh/wireproxy-awg
that referenced
this pull request
Jul 22, 2025
* Update README (whyvl#137) * Fix broken sandboxing resulting in SIGABRT (whyvl#136) * Fix HTTP proxy authentication to support both preemptive and challenge-response auth (whyvl#134) * Bump golang.org/x/crypto from 0.21.0 to 0.31.0 (whyvl#146) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0. - [Commits](golang/crypto@v0.21.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update README.md (whyvl#150) Fixed curl example command to work well with sudo * Fix PingRecord race condition (whyvl#149) * docs: add syntax highlighting and Go install command (whyvl#158) * docs: add syntax language for codeblocks * docs: add install instructions for Go * Make sure that closing one direction closes the other, too. (whyvl#159) * Make sure that closing one direction closes the other, too. * Pacify linter. * Bump golang.org/x/net from 0.23.0 to 0.33.0 (whyvl#160) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.23.0 to 0.33.0. - [Commits](golang/net@v0.23.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add IPRoyal referral link * Add hint to run Wireproxy as system daemon in rc.d-based system (whyvl#164) * Add hint for rc.d service * Update README.md --------- Co-authored-by: root <root@prox1.example.com> * fix: issue with omiting endpoint (whyvl#157) fixes whyvl#156 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Niko <niko@niko.lgbt> Co-authored-by: Luiz Henrique Gomes Palácio <lhpalacio@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yaroslav <yaroslaff@gmail.com> Co-authored-by: Takanori Hirano <me@hrntknr.net> Co-authored-by: Lars Gerber <75072836+larsgerber@users.noreply.github.com> Co-authored-by: Christian Speckner <christian.speckner@mayflower.de> Co-authored-by: pufferffish <me@windtfw.com> Co-authored-by: lexandr0s <lexandr0s@users.noreply.github.com> Co-authored-by: root <root@prox1.example.com> Co-authored-by: Emilien Devos <121870973+edevosc2c@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #156
Seems like this change broke the functionality: cb1f39b#diff-0e426a43248661127a0c0ee115aef7a1093b635f8993b3f7ebb1dd9f05b8f249L295-R329
Reverting from:
To
Fixed the issue.
I'm not well versed in the code nor Golang for that to be an issue to revert to the old code, but it seems to work fine. And all the following lines still use the same method "if sectionKey, err := section." and so on.