Skip to content

Conversation

@google-labs-jules
Copy link

Integrated React hooks directly into the generated Service Stub class. This allows usage like stub.useGreet() and stub.useGreetSuspense() instead of manual useGrpc wrapping or separate hook stubs. Updated generator logic and templates, and adjusted tests to match the new API.


PR created automatically by Jules for task 8122102525599011381 started by @wickedev

- Modified `ServiceGenerator` to add `use{Method}` and `use{Method}Suspense` methods directly to the generated Stub class.
- Updated `service.hbs` to generate these methods and import necessary hooks from `@hallow/react`.
- Removed the separate `HookStub` class as its functionality is now merged into the main Stub.
- Improved template path resolution in `ServiceGenerator` to work reliably in different environments.
- Updated tests to verify the new Stub structure and API.

This change allows developers to use hooks directly from the stub instance (e.g., `stub.useGreet(request)`) instead of manually wrapping `useGrpc`.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

- Modified `ServiceGenerator` to add `use{Method}` and `use{Method}Suspense` methods directly to the generated Stub class.
- Updated `service.hbs` to generate these methods and import necessary hooks from `@hallow/react`.
- Removed the separate `HookStub` class as its functionality is now merged into the main Stub.
- Improved template path resolution in `ServiceGenerator` to work reliably in different environments.
- Updated `packages/example-webpack` examples and tests to reflect the new API usage.
- Updated tests in `packages/generator` and `packages/plugin` to verify the new Stub structure and API.

This change allows developers to use hooks directly from the stub instance (e.g., `stub.useGreet(request)`) instead of manually wrapping `useGrpc`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant