Implement oneof parsing in proto-parser.js #2
Conversation
- Implemented `extractBalancedBody` helper to robustly handle nested braces in proto files, replacing fragile regex-based parsing. - Updated `parseMessages` to use balanced brace extraction, allowing correct parsing of messages containing nested blocks like `oneof`. - Implemented `parseOneofs` to extract and parse `oneof` definitions within messages. - Verified changes by adding a test case with `oneof` fields in `packages/test-client/src/service.proto` and running `packages/test-client/test-parser.js`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change implements parsing support for
oneoffields inpackages/test-client/proto-parser.js. Previously,oneoffields were ignored, and their presence inside a message body would break the message parsing due to regex limitations handling nested braces. The solution introduces a brace-counting mechanism to correctly extract message and oneof bodies, enabling accurate AST generation for messages with oneofs. This aligns the parser's output with the generator's expected AST structure.PR created automatically by Jules for task 19859372160941907 started by @wickedev