ci: Pr build latest commit #233
Merged
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ref parameter to all checkout steps to use PR head SHA - Update comment-pr job to display correct commit SHA with clickable link - Update sign job artifact naming to use PR head SHA for PR builds - Falls back to github.sha for tags and branch pushes (no change in behavior) This fixes an issue where: 1. Builds were done on the merge commit instead of actual PR commit 2. The SHA commented on PRs was the merge commit, not the PR head 3. Clicking the commit link showed a weird merge commit, especially after rebasing Co-authored-by: wharris <wharris@upscalews.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Co-authored-by: wharris <wharris@upscalews.com>
Code Coverage Report
|
📊 Code Coverage Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GitHub Actions to build pull requests against the actual branch head commit, ensuring accurate commit SHAs in comments and artifact names.
Note
Ensures CI runs against the actual PR head commit and surfaces the correct SHA in outputs.
ref: ${{ github.event.pull_request.head.sha || github.sha }}inactions/checkoutacross jobs (safety_checks,build,sign,unit-tests,integration-test,merge-integration-coverage,coverage-report,create-release)signnow usesPR_HEAD_SHAfor PRs; addsenv PR_HEAD_SHAfor accurate short SHA in file suffixesWritten by Cursor Bugbot for commit 80b0493. This will update automatically on new commits. Configure here.