feat: ui material design overhaul (formerly bottom sheet material) #237
Conversation
Code Coverage Report
|
📊 Code Coverage Summary
|
williscool
force-pushed
the
fix/bottom_sheet_styles_material_update
branch
from
9d50996 to
7ac3324
Compare
williscool
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Code Coverage Summary
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Code Coverage Summary
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Code Coverage Summary
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Code Coverage Summary
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| } | ||
| else { | ||
| Toast.makeText(this, R.string.event_was_created, Toast.LENGTH_LONG).show() | ||
| Snackbar.make(findViewById(android.R.id.content), R.string.event_was_created, Snackbar.LENGTH_LONG).show() |
There was a problem hiding this comment.
Snackbar messages not visible before activity finishes
Medium Severity
Replacing Toast with Snackbar where finish() is called immediately after causes user feedback to be lost. Unlike Toast, which is managed by WindowManager and persists after the activity closes, Snackbar is attached to the activity's view hierarchy and gets destroyed when finish() is called. Success messages like "Event was created" or "Event pre-snoozed" won't be visible to users.
Additional Locations (1)
| android:layout_marginEnd="8dp" | ||
| android:textAppearance="?attr/textAppearanceBodySmall" | ||
| android:textColor="?attr/colorOnSurfaceVariant" | ||
| android:visibility="gone" |
There was a problem hiding this comment.
Event time text invisible due to missing visibility change
Medium Severity
The card_view_event_time TextView now has android:visibility="gone" in the layout, but EventListAdapter.onBindViewHolder never sets visibility to VISIBLE when populating it. For special events, the adapter assigns detail2 from getSpecialDetail() to eventTimeText, but this text is never visible. The old layout had default visibility (visible), so this worked before. The adapter manages visibility for snoozedUntilText but not for eventTimeText.
📊 Code Coverage Summary
|
refs #15
Note
Major Material 3 modernization across UI with new components, pickers, and theming.
AlertDialogwithMaterialAlertDialogBuilder; convertToasttoSnackbarin activities/fragmentsSpinner/CheckBox/Switch/ImageButton/CardViewto Material equivalents (exposed dropdowns, MaterialCheckBox/MaterialSwitch/MaterialButton/MaterialCardView)MaterialDatePicker/MaterialTimePicker; remove custom picker layouts and related state plumbingTheme.Material3.DayNight, add M3 BottomSheet styles, app bar colors, and ripple/shape resourcesView/ViewGroupWritten by Cursor Bugbot for commit 6045907. This will update automatically on new commits. Configure here.