Skip to content

Make the whole collapsed block clickable #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukeTowers merged 2 commits into from
Jan 25, 2025
Merged

Make the whole collapsed block clickable #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc8eb28
make the whole collapsed block clickable
mjauvin Jan 23, 2025
4e7f21a
add empty line removed by mistake
mjauvin Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions formwidgets/blocks/assets/js/blocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,14 @@
this.$el.on('focus', '> .field-repeater-items > .field-repeater-item', this.proxy(this.onItemFocus))
this.$el.on('blur', '> .field-repeater-items > .field-repeater-item', this.proxy(this.onItemBlur))

this.$el.find('> ul > li > .repeater-item-collapsed-handle')
.css({'cursor': 'pointer', 'width': '100%'})
.on('click', this.proxy(this.toggleCollapse))

this.$el.find('> ul > li > .field-repeater-form > .form-group > label')
.css({'cursor': 'pointer', 'width': '100%'})
.on('click', this.proxy(this.toggleCollapse))

this.$el.one('dispose-control', this.proxy(this.dispose))

this.togglePrompt()
Expand Down
4 changes: 3 additions & 1 deletion formwidgets/blocks/partials/_block_item.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ class="close"
</div>
<?php endif ?>

<div class="repeater-item-collapsed-handle">&nbsp;</div>

<div class="repeater-item-title<?php if (!$this->previewMode && $sortable): ?> repeater-item-handle <?= $this->getId('items') ?>-handle"<?php endif ?>>
<span class="icon">
<i class="<?= $itemIcon ?>"></i>
Expand All @@ -56,7 +58,7 @@ class="block-config"
<i class="icon-cog"></i>
<input type="hidden" data-inspector-values name="<?= $widget->arrayName ?>[_config]" value="<?= e($groupConfig ?? '') ?>" />
</a>
<?php endif ?>
<?php endif ?>

<div class="field-repeater-form"
data-control="formwidget"
Expand Down
Loading