-
-
Notifications
You must be signed in to change notification settings - Fork 15
Support Monaco editor #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis PR migrates the code editor from ACE to Monaco, introduces AJAX-driven form widget reconstruction through a new behavior base class pattern, restructures migration code generation to use anonymous classes and separate up/down code blocks, and applies minor CSS styling updates with green highlighting classes for new translation indicators. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Controller
participant IndexOpsBehavior as IndexOperations<br/>Behavior
participant WidgetRegistry
participant FormWidget
Client->>Controller: AJAX request (widget-scoped handler)
Controller->>IndexOpsBehavior: handleFormWidgetAjax($handler)
rect rgb(200, 220, 255)
Note over IndexOpsBehavior: Parse widget alias from handler
IndexOpsBehavior->>WidgetRegistry: Check if widget exists
WidgetRegistry-->>IndexOpsBehavior: Widget missing or not found
end
rect rgb(220, 240, 220)
Note over IndexOpsBehavior: Reconstruct missing widget
IndexOpsBehavior->>IndexOpsBehavior: reconstructFormWidget($alias)
IndexOpsBehavior->>FormWidget: Build from POST data<br/>(form config, fields, alias)
FormWidget->>FormWidget: Set context/language
IndexOpsBehavior->>Controller: Bind widget to controller
Controller->>WidgetRegistry: Register reconstructed widget
WidgetRegistry-->>IndexOpsBehavior: Success
end
IndexOpsBehavior->>Controller: Continue normal handler flow
Controller->>FormWidget: Execute AJAX action
FormWidget-->>Client: AJAX response
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related: wintercms/winter#801
Summary by CodeRabbit
New Features
Style
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.