Fix direct navigation to JS-based sub menu items #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@LukeTowers When using Top menu instead, I get flaky behavior when switching to different CMS sub-menu items. Do you get this? |
Member
|
In fact, with Top menu location, CMS sub-menu just don't work. |
Member
Author
|
To be fair I didn't test that at all 😂 I'll take another look at it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6 by passing the desired sub menu item to the page as a hash parameter when the page is first loaded; then detects the presence of the hash parameter and uses it to load the selected child page in JS when the page itself first loads; at which point the on-page navigation handling can take over. There is a small flash of the wrong menu item being selected when the page first loads, but it was an acceptable trade-off for me for now.