winter 1.2.8 support #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@LukeTowers I started converting this plugin but encountered an issue with the default update view breadcrumbs... it is showing "Users" twice, as can be seen in the screenshot below:
|
Member
Author
|
The breadcrumb can be fixed by adding this commit to the diff --git a/modules/backend/layouts/_breadcrumb.php b/modules/backend/layouts/_breadcrumb.php
index c9f575539..cc56ddfda 100644
--- a/modules/backend/layouts/_breadcrumb.php
+++ b/modules/backend/layouts/_breadcrumb.php
@@ -12,7 +12,7 @@
<?php if ($menu): ?>
<ul>
<li><a href="<?= $menu->url ?>"><?= e(trans($menu->label)) ?></a></li>
- <?php if ($sideMenu): ?>
+ <?php if ($sideMenu && $sideMenu->url !== $menu->url): ?>
<li><a href="<?= $sideMenu->url ?>"><?= e(trans($sideMenu->label)) ?></a></li>
<?php elseif ($settingsItem): ?>
<li><a href="<?= $settingsItem->url ?>"><?= e(trans($settingsItem->label)) ?></a></li> |
13 tasks
LukeTowers
reviewed
Mar 18, 2025
LukeTowers
reviewed
Mar 18, 2025
LukeTowers
reviewed
Jun 18, 2025
LukeTowers
reviewed
Jun 18, 2025
LukeTowers
approved these changes
Jun 18, 2025
Member
LukeTowers
left a comment
LukeTowers
left a comment
There was a problem hiding this comment.
Approved pending merge of wintercms/winter#1312 and release of 1.2.8.
LukeTowers
reviewed
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on wintercms/winter#1312
Update Winter.User to use formcontroller behavior's default views.