WPB-21744: fix email verification resend for SCIM users #4916
Conversation
zebot
added
the
ok-to-test
| bindResponse (Spar.updateScimUser owner scimToken aliceId scimUser) $ \resp -> do | ||
| resp.status `shouldMatchOneOf` [Number 200, Number 201, Number 204] | ||
|
|
||
| -- 7. Alice tries to resend verification for B (client side) |
There was a problem hiding this comment.
hum, tricky!
when user is upgraded to scim, old validation keys need to be invalidated or deleted. from then on, alice must not be able to change her email address herself any more.
what should work is that if user is updated using scim, and that triggers an email being sent, then admin should be able in team-management to re-send that email.
i think what you are testing is that alice can still update her email address after being put under scim management if she has initiated the change before. that should actually fail.
There was a problem hiding this comment.
Actually, I confused myself, I have rewrote the test so it represents the bug.
Can you check it is sync with the reported issue please?
If so, the test is passing, should I simply close the JIRA ticket or should I merge the test too?
blackheaven
force-pushed
the
gdifolco/WPB-21744-scim-fix-resending-verification-email
branch
from
aea6d81 to
ac16329
Compare
| let cookie = fromJust $ getCookie "zuid" resp | ||
| pure ("zuid=" <> cookie, token) | ||
|
|
||
| -- 3. Alice requests email change to B (pending state) |
There was a problem hiding this comment.
argh, i always get confused by this, sorry i didn't notice this before writing my earlier comments: i think the ticket is about inviting the user, not updating its email address.
blackheaven
force-pushed
the
gdifolco/WPB-21744-scim-fix-resending-verification-email
branch
from
6607637 to
e3325f4
Compare
https://wearezeta.atlassian.net/browse/WPB-21744
Checklist
changelog.d