Skip to content

Also capture metadata on linux #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
passsy wants to merge 9 commits into
base: stable
Choose a base branch
from
Open

Also capture metadata on linux #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f63a23
No special handling for linux
passsy Feb 12, 2024
a5eeef4
Remove code
passsy Feb 12, 2024
12c8823
Show exact dependencies
passsy Feb 12, 2024
ec52645
Also test on 3.7.3
passsy Feb 12, 2024
ecbe8dc
Try Flutter 3.3.10
passsy Feb 12, 2024
637113b
Do now swallow error
passsy Feb 12, 2024
73e0473
Merge branch 'stable' into capture-metadata-on-linux
passsy May 5, 2024
e9a9df6
Swallow linux error again
passsy May 5, 2024
731f088
Fix override
passsy May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,35 @@ jobs:
- uses: actions/checkout@v3
- name: Flutter version
run: flutter doctor -v
- name: Download dependencies
run: ./wiresdk deps
- name: print deps
run: cd examples/theming && ./../../wiresdk flutter pub deps
- name: Test
run: ./wiresdk test
- name: Build
run: cd examples/theming && ./../../wiresdk flutter build web

pr-flutter_3_3_10:
runs-on: ubuntu-latest
container:
image: cirrusci/flutter:3.3.10
steps:
- uses: actions/checkout@v3
- name: Flutter version
run: flutter doctor -v
- name: Download dependencies
run: ./wiresdk deps
- name: print deps
run: cd examples/theming && ./../../wiresdk flutter pub deps
- name: Test
run: ./wiresdk test
- name: Build
run: cd examples/theming && ./../../wiresdk flutter build web
- name: Download dependencies
run: |
# Override dependencies
printf "dependency_overrides:\n checks: 0.2.2\n meta: 1.9.0\n test_api: 0.4.9" >> pubspec.yaml

# The override syntax does not work with Flutter 3.0
#./wiresdk flutter pub add 'override:checks:0.2.2'

printf "dependency_overrides:\n checks: 0.2.2\n meta: 1.9.0\n test_api: 0.4.12" >> pubspec.yaml
./wiresdk deps
- name: Test
run: ./wiresdk test
Expand Down
9 changes: 0 additions & 9 deletions lib/src/metadata/meta_data_collector.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import 'dart:async';
import 'dart:io';

import 'package:device_info_plus/device_info_plus.dart';
import 'package:flutter/foundation.dart';
import 'package:package_info_plus/package_info_plus.dart';
import 'package:wiredash/src/_wiredash_internal.dart';
import 'package:wiredash/wiredash.dart';
Expand Down Expand Up @@ -95,12 +93,6 @@ class MetaDataCollector {
}

Future<DeviceInfo> _collectDeviceInfo() async {
if (!kIsWeb && Platform.isLinux) {
// it just hangs on linux for some reason
// https://github.com/fluttercommunity/plus_plugins/issues/1552
return const DeviceInfo();
}

try {
final deviceInfo = await DeviceInfoPlugin().deviceInfo;

Expand Down Expand Up @@ -162,7 +154,6 @@ class MetaDataCollector {
// https://github.com/fluttercommunity/plus_plugins/issues/1552
return const DeviceInfo();
}

reportWiredashInfo(
e,
stack,
Expand Down