Sink key management parameters for SetConfigRequest #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new functions for write only config fields(similar to read only fields) and move key parameters there.
Using a nested dictionary under new_config parameter doesn't follow the existing convention (such as the app_config and earlier key related entries), but it should make it easier to maintain the new_config dictionary in the long run if we have a structure which is more similar to the SinkNewConfig structure in protobuf.
sgunes-wirepas
requested review from
GwendalRaoul,
MauriKuorilehto and
teemupiiroinenwirepas
| "app_config_seq": 300, | ||
| "app_config_data": bytes.fromhex("90807060"), | ||
| "channel_map": 120, | ||
| "cipher_key": bytes.fromhex("102030"), |
There was a problem hiding this comment.
There is some zero padding in the gw for the keys?
Contributor
Author
There was a problem hiding this comment.
No, the gateway would just return an error if the key size is incorrect. This library doesn't do any checks as long as the protobuf messages are valid. It helps with testing, we can generate "bad" messages using this library.
MauriKuorilehto
approved these changes
Aug 20, 2025
|
|
||
|
|
||
| def parse_config_keys(message_obj, dic): | ||
| def parse_config_wo(message_obj, dic): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for network_keys and management_keys fields under SinkNewConfig, as well as the SINK_KEY_MANAGEMENT_V1 feature flag.