-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Document custom image service props #12897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Description (required)
Documents the ability to type additional image props added in withastro/astro#15014
For Astro version:
5.16.6. See astro PR #15014 (exact version subject to change if a patch is released before)I’ll note that this feature is a little tricky to document. It follows the same pattern we use for the
App.Localstype used by middleware (see “Middleware types” in the docs), but unlike middleware this is maybe more likely to be used by a library, so the types also need exposing somehow to the user. There are a few different ways to do this, but it feels out of scope to document in the section I added.