-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Complete overhaul, removing all wled code #5282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete overhaul, removing all wled code #5282
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces a comprehensive ArkLights PEV lighting system with Git hooks for secret prevention, a complete Android Kotlin/Compose application for device control via Bluetooth, extensive web-based and native UI components, detailed documentation, and supporting build/setup tooling across multiple platforms. Changes
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Reasoning: This PR is substantial and heterogeneous, spanning 80+ new files across multiple distinct domains—Bash scripting (Git hooks), Kotlin/Jetpack Compose (Android app with services, ViewModels, UI components), JavaScript/HTML/CSS (web UI), Python (utility scripts), C++ (firmware patches), and extensive Markdown documentation. The Android app introduces significant logic density with Bluetooth state management, BLE GATT callbacks, permission handling, coroutine-based async operations, and a comprehensive ViewModel architecture. The web UI includes complex real-time status polling, calibration workflows, and OTA update handling. Multiple file additions require individual reasoning despite some repetitive patterns (e.g., similar API service methods, UI control functions). The breadth of technologies and interrelated components necessitates thorough cross-domain understanding. Possibly related PRs
Suggested reviewers
✨ Finishing touches
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (198)
📒 Files selected for processing (102)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Feature/direction based headlight switching
Summary by CodeRabbit
Release Notes
New Features
Documentation
Infrastructure
✏️ Tip: You can customize this high-level summary in your review settings.