Skip to content

V0.15.3 no v #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamVR7 wants to merge 6 commits into from
Closed

V0.15.3 no v #5284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60fa709
Comment out DynamicBuffer usage in mqtt.cpp
AdamVR7 Jan 8, 2026
f77858e
Add GitHub Actions workflow for ESP32 build
AdamVR7 Jan 8, 2026
345e18a
Modify GitHub Actions to build ESP32dev firmware
AdamVR7 Jan 8, 2026
f3f6d7f
Update ESP32 build workflow to prepare single output bin
AdamVR7 Jan 8, 2026
630d7d2
Add upload artifact step in build workflow
AdamVR7 Jan 8, 2026
054457b
Add blank line before upload-artifact step
AdamVR7 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions .github/workflows/build-esp32.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: Build WLED ESP32dev (v0.15.3-no-v)

on:
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout current branch
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.11"

- name: Cache PlatformIO
uses: actions/cache@v4
with:
path: |
~/.platformio
key: ${{ runner.os }}-pio-${{ hashFiles('platformio.ini') }}
restore-keys: |
${{ runner.os }}-pio-

- name: Install PlatformIO
run: pip install --upgrade platformio

- name: Build firmware (esp32dev only)
run: pio run -e esp32dev

- name: Prepare single output bin
run: |
set -e
mkdir -p out
# Обычно итоговый файл здесь:
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Replace Russian comment with English.

The comment "# Обычно итоговый файл здесь:" (Usually the final file is here) should be in English for consistency with the rest of the codebase.

📝 Proposed fix 
-          # Обычно итоговый файл здесь:
+          # The firmware.bin output is typically found here:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Обычно итоговый файл здесь:
# The firmware.bin output is typically found here:
🤖 Prompt for AI Agents 
In @.github/workflows/build-esp32.yml at line 37, Replace the Russian inline
comment "# Обычно итоговый файл здесь:" with an equivalent English comment such
as "# Usually the final file is here:" to match the repository's
English-language comments and maintain consistency.

if [ -f ".pio/build/esp32dev/firmware.bin" ]; then
cp ".pio/build/esp32dev/firmware.bin" "out/WLED_0.15.3_ESP32dev_no_v.bin"
else
echo "ERROR: firmware.bin not found"
ls -lah .pio/build/esp32dev || true
exit 1
fi
ls -lh out/*.bin
sha256sum out/*.bin

- name: Upload firmware artifact (single file)
uses: actions/upload-artifact@v4
with:
name: WLED_0.15.3_ESP32dev_no_v
path: out/*.bin


14 changes: 7 additions & 7 deletions wled00/mqtt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,13 @@ void publishMqtt()
strcat_P(subuf, PSTR("/status"));
mqtt->publish(subuf, 0, true, "online"); // retain message for a LWT

// TODO: use a DynamicBufferList. Requires a list-read-capable MQTT client API.
DynamicBuffer buf(1024);
bufferPrint pbuf(buf.data(), buf.size());
XML_response(pbuf);
strlcpy(subuf, mqttDeviceTopic, 33);
strcat_P(subuf, PSTR("/v"));
mqtt->publish(subuf, 0, retainMqttMsg, buf.data(), pbuf.size()); // optionally retain message (#2263)
//// TODO: use a DynamicBufferList. Requires a list-read-capable MQTT client API.
//DynamicBuffer buf(1024);
//bufferPrint pbuf(buf.data(), buf.size());
//XML_response(pbuf);
//strlcpy(subuf, mqttDeviceTopic, 33);
//strcat_P(subuf, PSTR("/v"));
//mqtt->publish(subuf, 0, retainMqttMsg, buf.data(), pbuf.size()); // optionally retain message (#2263)
#endif
}

Expand Down