Skip to content

Conversation

@dhillondeep
Copy link

No description provided.

@dhillondeep dhillondeep requested a review from Mogball October 24, 2018 08:48
Copy link
Contributor

@Mogball Mogball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why you needed to change anything if wio is backwards compatible


#include <new.h>

void* operator new(decltype(sizeof(0)), void* ptr) noexcept {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included with wlib-tmp, we don't need it again

#include <wlib/utility>
#include <wlib/type_traits>
#include <wlib/mem/Detail.h>
#include <wlib/mem/New.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include New.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants