Skip to content

Ensure .NET 8, 9, and 10 SDKs are available in CI workflow #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Ensure .NET 8, 9, and 10 SDKs are available in CI workflow #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6c3767
Initial plan
Copilot Dec 31, 2025
8c8e0df
Update CI workflows to ensure .NET 8, 9, and 10 SDKs are available
Copilot Dec 31, 2025
0daea59
Simplify CI .NET setup and revert publish workflow to original
Copilot Dec 31, 2025
5f77a2d
Add quotes to global-json-file for consistency
Copilot Dec 31, 2025
23f8836
Update global.json to .NET 10.0.101 and CI to install .NET 9 instead …
Copilot Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ jobs:
with:
fetch-depth: 0

- name: Setup .NET
uses: actions/setup-dotnet@v5
with:
global-json-file: "global.json"
dotnet-version: |
9.0.x
8.0.x
Comment on lines +32 to +38
Copy link

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI workflow is being configured to install .NET 8.0.x, 9.0.x, and 10.0.101 (from global.json), but the project does not target .NET 9 or .NET 10 frameworks. The main library targets net462, net8.0, and netstandard2.0, while the test project only targets net8.0 (and net462 on Windows).

Installing SDK versions 9.0.x and 10.0.x is unnecessary and adds overhead to the CI pipeline. Only .NET 8.0.x SDK should be required to build and test this project. If there's a specific reason why newer SDKs are needed (e.g., for tooling or build features), this should be documented.

Copilot uses AI. Check for mistakes.

- name: Authenticate to Azure Artifacts
uses: workleap/wl-reusable-workflows/az-artifact-authenticate@main
with:
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "9.0.306",
"version": "10.0.101",
Copy link

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK version is being updated from 9.0.306 to 10.0.101, but the project files do not target any .NET 10 frameworks. The main library targets net462, net8.0, and netstandard2.0, while the test project targets net8.0 (and net462 on Windows). There is no evidence in the codebase that .NET 10 is required.

Additionally, this change contradicts the project's documented requirement of .NET 9.0.304 SDK. If there's a specific reason for requiring .NET 10 SDK despite not targeting net10.0 frameworks, this should be documented in the PR description or commit message.

Copilot uses AI. Check for mistakes.
"rollForward": "latestMinor",
"allowPrerelease": false
}
Expand Down
Loading