feat: Add Cookie Chunking to handle large JWTs #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknisi
force-pushed
the
nicknisi/cookie-chunking
branch
from
7e6774c to
481ece3
Compare
nicknisi
changed the title
nholden
approved these changes
Oct 28, 2025
Comment on lines
+71
to
+78
| // Delete all session cookies (base + chunks) | ||
| const allCookies = nextCookies.getAll(); | ||
| for (const cookie of allCookies) { | ||
| // Delete base cookie or any chunked cookie (cookieName.0, cookieName.1, etc.) | ||
| if (cookie.name === cookieName || (cookie.name.startsWith(`${cookieName}.`) && /\.\d+$/.test(cookie.name))) { | ||
| nextCookies.delete({ name: cookie.name, domain, path, sameSite, secure }); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Seeing some regex duplication here. Should cookie-chunker be responsible for finding the cookie names from a list of all cookies?
Comment on lines
+179
to
+182
| request.cookies.getAll().forEach((cookie) => { | ||
| existingCookies[cookie.name] = cookie.value; | ||
| }); | ||
| const encryptedSession = readValue(cookieName, existingCookies); |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, cookie-size can be exceeded by larger JWTs, which fails with odd errors as a result of the cookie not being set.
This PR introduces a new cookie-chunking feature that will automatically break up too-large JWTs across several cookies, reassembling it seamlessly when requested.
If no chunking is required, the cookie will remain as
WORKOS_COOKIE_NAME(defaulted tosos-session. If chunking is needed it will be${WORKOS_COOKIE_NAME || 'wos-session'}.${chunkIndex}.