feat: First implementation of the module #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
dbc2019
previously approved these changes
Apr 9, 2025
dbc2019
left a comment
dbc2019
left a comment
There was a problem hiding this comment.
Hi Jeremy,
Review OK. To me seems that everything is in place. If we can wait to merge, maybe is good to wait until CI is fixed, so puppet can be install on apt based OS's
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
gabridc
requested changes
Apr 14, 2025
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
gabridc
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.