Auto-switch the node version #38
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-day
commented
May 22, 2023
| if [[ ${availablenodeversions[*]} =~ v14* ]]; | ||
| then | ||
| echo "v14 found. Switching your current version..."; | ||
| nvm use 14; |
Collaborator
Author
There was a problem hiding this comment.
Note that nvm use only uses the target version while the shell is running. So if you are using a different version of node (say, 18.16) and run node -v after the script stops, you will be shown as still using 18.16.
I think this is okay since the other child node dependencies will be installed while using node 14 in the shell, but I could be wrong...
We could also change the user's default node version to make the change persist.
mike-day
commented
May 22, 2023
| echo "v14 found. Switching your current version..."; | ||
| nvm use 14; | ||
| else | ||
| echo "Please install node v14, then run this script again."; |
Collaborator
Author
There was a problem hiding this comment.
This installation could probably be automated as well, though we will have to check python dependencies etc as the install might fail for an older version of node with a current version of python installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just some playing around to see if auto-switching the node version works.