Add golang linters #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senthalan
reviewed
May 14, 2025
| - EXC0013 | ||
| - EXC0014 | ||
| exclude-dirs: | ||
| - clients/kubernetes/types # Exclude the kubernetes client types copied from external sources |
Contributor
There was a problem hiding this comment.
Will these exclude-dirs specific for a project ?
Contributor
There was a problem hiding this comment.
Then we can't have this as the common rule?
Does go linters allows to merge two rules files? So we can have one with the common rules here and each project can maintain project specific ones in each repos ?
| # List of functions to exclude from checking, where each entry is a single function to exclude. | ||
| # See https://github.com/kisielk/errcheck#excluding-functions for details. | ||
| exclude-functions: | ||
| - (*go.uber.org/zap.Logger).Sync |
Contributor
There was a problem hiding this comment.
Will these exclude-functions specific for a project ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add golang linters
Goals
Maintain golang linters in a single repository.