Skip to content

Conversation

@Jancis
Copy link
Member

@Jancis Jancis commented Sep 5, 2025

Replaces https://pkg.go.dev/github.com/mittwald/go-helm-client library with official helm library

@Jancis Jancis requested a review from Copilot September 5, 2025 13:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the third-party github.com/mittwald/go-helm-client library with the official Helm v3 library (helm.sh/helm/v3). The refactor consolidates Kubernetes client initialization into a common utility function and updates all Helm operations to use the official APIs.

  • Migrates from unofficial go-helm-client to official helm.sh/helm/v3 library
  • Consolidates Kubernetes client initialization into a reusable GetKubeClient() function
  • Updates all Helm operations (list, get, uninstall) to use official Helm action API

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/common/kube.go New file containing centralized Kubernetes client initialization
internal/common/ciReleaseFunctions.go Updates Helm uninstall operations and adds failed release cleanup using official APIs
go.mod Removes dependency on github.com/mittwald/go-helm-client
cmd/ciScriptsEsInitRemove.go Replaces inline K8s client setup with common utility function
cmd/ciReleaseWakeup.go Migrates Helm client initialization to official library
cmd/ciReleaseList.go Updates release listing to use official Helm action API
cmd/ciReleaseDiff.go Replaces inline K8s client setup with common utility function
cmd/ciReleaseDeploy.go Updates K8s client initialization and replaces shell script with Go function
cmd/ciReleaseDelete.go Migrates Helm client initialization and uninstall operations to official APIs
cmd/ciReleaseCleanfailed.go Simplifies implementation by using new common cleanup function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Jancis Jancis force-pushed the feature/helm-library branch from bfea9ec to 8fa3678 Compare September 5, 2025 13:19
@Jancis Jancis force-pushed the feature/helm-library branch from 8fa3678 to 51898f0 Compare September 5, 2025 13:23
@Jancis Jancis requested a review from Rade333 September 5, 2025 13:37
@Rade333 Rade333 merged commit 8e39417 into master Sep 9, 2025
12 checks passed
@Rade333 Rade333 deleted the feature/helm-library branch September 9, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants