Add slight delay for Xcode 16, iOS 18 #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| internal func expectMainQueueExhaustion() -> XCTestExpectation { | ||
| let exhaustion = expectation(description: "main queue exhaustion") | ||
| DispatchQueue.main.async { | ||
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.1, execute: { |
There was a problem hiding this comment.
Nice! Can we make it an even shorter time? Like using this instead:
DispatchQueue.main.asyncAfter(deadline: .now() + .leastNormalMagnitude, execute: {
Contributor
Author
There was a problem hiding this comment.
will test on the PR in WWMobile
Contributor
Author
There was a problem hiding this comment.
it fails unfortunately
added 2 commits
January 13, 2025 11:57
russellsavageww
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a need for a slight delay for exhausting the main queue when using iOS 18 and xcode 16.
This fix appears to reliably fix expected navigation changes.
I tested here in this PR that had failing tests and they all succeed now.
https://github.com/WW-Digital/ios-mobile/pull/5248