Fix robust_fit for large timestamps by subtracting offset #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstenner
reviewed
Dec 29, 2020
tstenner
reviewed
Dec 29, 2020
Contributor
Author
|
Before review of #74 , I'd like to this to be reviewed and merged. Are there any outstanding concerns? |
Contributor
Yes, it hasn't been merged yet :-) |
Contributor
|
Thanks @cboulay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported here and by user in Slack.
Briefly, very large timestamp values (especially on systems using seconds since 1970) lead to instabilities due to insufficient numerical precision. Here we subtract a constant from the timestamps before calculating the fit between timestamps and offsets. The offset is added back before returning.
There was also a little extra to be done to keep winsor_threshold functioning properly.
Sister PR in Matlab: xdf-modules/xdf-Matlab#9