-
-
Notifications
You must be signed in to change notification settings - Fork 7
Tryed to add a new structure. #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
schvarts1
wants to merge
4
commits into
yannis300307:main
Choose a base branch
from
schvarts1:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8a33731
Add house1.json with house structure data
schvarts1 3c4efaa
Add HOUSE1 structure from binary file
schvarts1 32ffbfe
Revise CONTRIBUTING.md for clarity and guidelines
schvarts1 1f4f289
Included other characteristics CODE_OF_CONDUCT.md
schvarts1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,30 @@ | ||
| # How to contribute to Numcraft? | ||
| ## Steps for creating good issues or pull requests. | ||
| If your issue is related to a bug, please give the full error message if one is shown. Please describe the context of the bug, the OS version, the calculator model and if possible, the release version or the latest commit. | ||
| If your issue is related to a bug, please give the **full error message** if one is shown. Please describe the *context of the bug*, the *OS version*, the *calculator model* (n110, n115 or n120) and *if possible, the release version or the latest commit*. | ||
|
|
||
| If you are asking for an enhancement, please concider the hardware resptrictions : | ||
| - Multiplayer is currently impossible | ||
| - No sound | ||
| - Numcraft must be compatible with N0110, N0115 and N0120. So make sure that the game runs on N0110 or N0115. | ||
| - and a lot of other restrictions | ||
| - extremelly low amount of ram | ||
| If you are asking for an enhancement, please concider the hardware restrictions : | ||
| - Multiplayer is currently impossible (due to lack of external connectivity availability) | ||
| - No sound (no speakers) | ||
| - Numcraft must be compatible with N0110, N0115 and N0120. So make sure that the game runs on N0110 or N0115. (try not to crash ram/cpu) | ||
| - and a lot of other restrictions (storage, etc...) | ||
| - extremelly low amount of ram (256 KO of RAM) | ||
|
|
||
| Before reporting a bug please read the `Known bugs` section and the `Roadmap` before asking for features. | ||
|
|
||
| ## About vibe codding and AI | ||
| Nowdays, vibe codding is more and more used. It's an easy way to write code quickly but AIs have a big problem when it comes to programming on a calculator: they don't know the hardware. This is mainly due to the lack of documentation about this hardware. Moreover, I prefer code that is written by humans. For me, code is an art (and particularly video games) so I encourage handwriting code. | ||
|
|
||
| So please, avoid vibe codding if you can. If you still want to use AI to write your code please: | ||
| So please, **avoid vibe codding if you can**. If you still want to use AI to write your code please: | ||
| - Limit the work of the AI to a single function or a few ones. | ||
| - Don't let the AI architecturing the project. | ||
| - Don't let the AI modifiying existing code when it's not necessary. | ||
| - Don't let the AI writing very low level code. | ||
| - Carrefully read the generated code. Do not open a pull request if it works, read the entiere generated code before openning it. And be extremelly careful about the rendering. | ||
| - **⚠️ Carefully read the generated code!** Do not open a pull request if it works, read the entiere generated code before openning it. And be extremelly careful | ||
| about the rendering. | ||
| - **Test the code yourself on the simulator or a calculator to validate it.** | ||
|
|
||
| ## Code guideline | ||
| - All the code including, function names, commentaries, structures names, etc... must be in english. | ||
| - All the code including, function names, commentaries, structures names, etc... must be in english. (no l18n for now (may be implemented later)) | ||
| - When a part of your code is not easy to understand or is very abstract, please add comments. Functions like `place_air` and that have only a few lines of code doesn't necessary need comments. | ||
| - Please fit your code to the current architecture of the project. Do not refactor the whole project. If you strongly believe that the code needs a complete refactor, please open a discussion thread first. | ||
| - Please **fit your code to the current architecture of the project**. Do not refactor the whole project. If you strongly believe that the code needs a complete refactor, please open a discussion thread first. | ||
| - If you use the simulator to code your PR, please remember that your code will run on machines that are thousands of time less powerful than your computer. So always try your code on real hardware before openning a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The name of the struct is incorrect. It must be house1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "name": "tree1", | ||
| "size": [ | ||
| 4, | ||
| 4, | ||
| 4 | ||
| ], | ||
| "data": [ | ||
| [ | ||
| "xxxx", | ||
| "xuux", | ||
| "xuux", | ||
| "xxxx" | ||
| ], | ||
| [ | ||
| "ouuo", | ||
| "uaau", | ||
| "uaau", | ||
| "oaao" | ||
| ], | ||
| [ | ||
| "ouuo", | ||
| "uaau", | ||
| "uaau", | ||
| "oaao" | ||
| ], | ||
| [ | ||
| "xxxx", | ||
| "xxxx", | ||
| "xxxx", | ||
| "xxxx" | ||
| ] | ||
| ], | ||
| "palette": { | ||
| "a": 0, | ||
| "x": 6, | ||
| "o": 7, | ||
| "u": 9 | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CODE_OF_CONDUCT.md has nothing to do with the structure. Please open a discussion if you want to change something in CODE_OF_CONDUCT.md or CONTRIBUTING.md