fix: revert disks indicators 0859c37

[DaryaVorontsova]

… (#3142)"

This reverts commit 0859c37.

Greptile Overview

Greptile Summary

This PR cleanly reverts commit 0859c37, which introduced visual design updates to disk indicators across the console.

What's being reverted:

• Interactive hover system: Removed the coordinated hover highlighting feature where hovering over a disk would highlight it and dim others in the same column
• Design token migration: Reverted modern design tokens (var(--g-border-radius-*), var(--g-spacing-*)) back to original values
• State management refactoring: Moved highlight state management back from parent components to component-level
• HoverPopup improvements: Removed useEffect-based callback timing that prevented stale closures
• Context-aware highlighting: Removed isTopLevelStorageContext helper and conditional highlighting logic
• CSS architecture: Removed hover-dim-column-class mixin and hover color variants from entity-state-colors

Revert quality:
The revert is clean and complete, affecting 31 files with 199 insertions and 469 deletions. All changes properly restore the codebase to its state before the original feature was merged. The diff is exactly the inverse of the original commit.

Why this might be reverted:
Based on the CI results showing flaky tests and increased bundle size, this revert likely addresses issues discovered after the original feature was merged.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk - it's a clean revert of a previous commit
• The revert is performed correctly using git revert, which ensures a clean inverse of the original changes. All 31 files are properly reverted, removing the hover interaction system, design token updates, and state management changes. The code returns to a known stable state that was previously working in production. No manual merge conflicts or incomplete reversions are present.
• No files require special attention - the revert is clean and complete

Important Files Changed

File Analysis

Filename	Score	Overview
src/components/DiskStateProgressBar/DiskStateProgressBar.tsx	5/5	Removed highlighted, darkened, and noDataPlaceholder props, reverting to simpler component interface
src/components/HoverPopup/HoverPopup.tsx	5/5	Removed useEffect callback timing logic, reverting to simpler debounce implementation
src/styles/mixins.scss	5/5	Removed hover color variants and hover-dim-column-class mixin, simplified entity-state-colors mixin
src/containers/Storage/Disks/Disks.tsx	5/5	Moved highlight state back to component-level, removed prop-based highlight management
src/containers/Storage/VDisks/VDisks.tsx	5/5	Removed highlightedVDisk and setHighlightedVDisk props, simplifying component interface
src/components/VDisk/VDiskWithDonorsStack.tsx	5/5	Removed highlight state management and callbacks, simplified donor stack rendering
src/containers/Storage/PaginatedStorageGroupsTable/columns/columns.tsx	5/5	Removed isTopLevelStorageContext usage, highlight state props, and adjusted column widths back to original values
src/containers/Storage/utils/index.ts	5/5	Removed isTopLevelStorageContext helper function that was used for context-aware highlighting

Sequence Diagram

sequenceDiagram
    participant User
    participant Component as Disks/VDisks Component
    participant VDisk as VDisk Item
    participant HoverPopup
    participant ProgressBar as DiskStateProgressBar

    Note over User,ProgressBar: BEFORE REVERT (removed functionality)
    User->>VDisk: Hover over disk
    VDisk->>HoverPopup: onMouseEnter
    HoverPopup->>HoverPopup: debouncedHandleShowPopup (delay)
    HoverPopup->>HoverPopup: setIsPopupVisible(true)
    HoverPopup->>HoverPopup: useEffect triggers callback
    HoverPopup->>Component: onShowPopup → setHighlightedVDisk(id)
    Component->>VDisk: Pass highlighted={true}, darkened={false/true}
    VDisk->>ProgressBar: Render with highlight/darken states
    Note over ProgressBar: CSS hover-dim-column-class applies dimming
    
    Note over User,ProgressBar: AFTER REVERT (current state)
    User->>VDisk: Hover over disk
    VDisk->>HoverPopup: onMouseEnter
    HoverPopup->>HoverPopup: debouncedHandleShowPopup (delay)
    HoverPopup->>HoverPopup: setIsPopupVisible(true)
    HoverPopup->>Component: onShowPopup (inline handler)
    Component->>Component: setHighlightedVDisk(id) - local state
    Component->>VDisk: Pass showPopup={true}
    VDisk->>ProgressBar: Render without highlight states
    Note over ProgressBar: No coordinated highlighting across columns

Loading

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total	Passed	Failed	Flaky	Skipped
384	381	0	1	2

Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔽

Current: 62.50 MB | Main: 62.51 MB
Diff: 0.02 MB (-0.02%)

✅ Bundle size decreased.

ℹ️ CI Information

• Test recordings for failed tests are available in the full report.
• Bundle size is measured for the entire 'dist' directory.
• 📊 indicates links to detailed reports.
• 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

[greptile-apps]

_{29 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}