Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/oss-fuzz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fuzz-seconds: 600
dry-run: false
- name: Upload Crash
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
if: failure()
with:
name: artifacts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code patch you provided looks like a minor change in the GitHub Actions workflow. Here is a brief code review:

  1. Bug Risk:

    • The change from v4 to v5 in the actions/upload-artifact may introduce potential risks if there are breaking changes or compatibility issues between those versions. It's important to check the release notes for v5 of actions/upload-artifact to ensure compatibility with your current workflow.
  2. Improvement Suggestions:

    • Consider incorporating more conditionals or checks to further refine when artifacts are uploaded. This can help optimize the workflow and prevent unnecessary artifact uploads.
    • Add more detailed comments describing what each step does, especially if the workflow becomes more complex.

Overall, if the upgrade from v4 to v5 doesn't pose any compatibility issues and the rest of your workflow is functioning as expected, this change seems relatively low-risk and should be straightforward to implement. Remember to test the updated workflow thoroughly after making this change.

Expand Down
Loading