Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/oss-fuzz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
fuzz-seconds: 600
dry-run: false
- name: Upload Crash
uses: actions/upload-artifact@v5
uses: actions/upload-artifact@v6
if: failure()
with:
name: artifacts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review:

  • This patch upgrades the action actions/upload-artifact from version 5 to version 6, which is a good practice to ensure you are using the latest features and improvements.
  • The condition if: failure() specifies that artifact uploading will only happen if the job has failed, which seems intentional based on the context.

Suggestions for improvement:

  • Consider adding a comment or descriptive text above or alongside the code to explain why the artifact upload happens only in case of failure. This can help future maintainers understand the intent behind this behavior.
  • Check the official release notes or documentation for changes between versions 5 and 6 of actions/upload-artifact to see if there are new features or considerations that you might want to leverage or be aware of.
  • Make sure tests cover this functionality to ensure it behaves as expected during failures.

Overall, the code patch seems like a reasonable update without any obvious bugs in the provided context.

Expand Down
Loading