For reports items in entity and by entity #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Wolvverine
changed the title
yllen
reviewed
Sep 16, 2022
|
|
||
| if (!$this->childrens) { | ||
| return $link . " " . $this->getSqlField() . "='" . $this->getParameterValue() . "' "; | ||
| return $link . " " . $sqlField . "='" . $this->getParameterValue() . "' "; |
Owner
There was a problem hiding this comment.
where is define $sqlField if $tableName is empty?
Owner
|
Can you give an example of use of your new function? |
Author
|
Yes, it is similar to location report, only for entity. |
(The used SELECT statements have a different number of columns ...)
Author
|
@yllen I added ignoring object tables in "infocom_types" added in v10 with different table structure. |
Owner
|
For a new report, just post in the pull request the file of the report, not file of locale and empty file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.