-
Notifications
You must be signed in to change notification settings - Fork 67
Chore: Per project bundle #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # client/ayon_core/settings/lib.py
|
And what you did? Which process you've spawned and how? |
.\manage.ps1 run --project TestProejctFirst, it will print correct bundles, than it opens new terminal window and print the other output |
antirotor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is what we found out during testing:
- whenever there is process that cannot be run in the context of project bundle, it should state so (log some message) before running another process in studio bundle context
- web actions are not respecting project bundle settings (tray publisher)
- when you run
ayon_consolewith project bundle set, any new project will use justayonprocess (so new console window won't open)
Added log to tray logic causing this.
Should be fixed now.
I think it is not related to this PR. There is upcoming PR here that might fix it, but I'd rather test it together when this is merged. |
antirotor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and it works!
| return time.time() > self._outdate_time | ||
|
|
||
|
|
||
| def _get_addons_settings( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could use typehints 🤖


Changelog Description
Adding support for per project bundles.
Additional info
Core addon is aware of per project bundles and is capable of handling them. Addons manager is discovering correct addons based on project and project bundle, CLI functionality handles
--projectargument with it's value if called command does snot expect project argument to be filled.Testing notes: