Skip to content

Conversation

@iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 16, 2025

Changelog Description

Adding support for per project bundles.

Additional info

Core addon is aware of per project bundles and is capable of handling them. Addons manager is discovering correct addons based on project and project bundle, CLI functionality handles --project argument with it's value if called command does snot expect project argument to be filled.

Testing notes:

  1. Per project bundles should work when combined with Chore: Per project bundles ayon-launcher#238 .

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/S labels Jun 16, 2025
@iLLiCiTiT iLLiCiTiT added type: feature Adding something new and exciting to the product sponsored This is directly sponsored by a client or community member bump minor labels Jun 16, 2025
@iLLiCiTiT iLLiCiTiT self-assigned this Jun 16, 2025
@iLLiCiTiT iLLiCiTiT removed type: enhancement Improvement of existing functionality or minor addition labels Jun 18, 2025
@antirotor
Copy link
Member

I am not sure where exactly report issues (launcher or core) but I'll post this one here:

At first, it looks like it is resolving the bundle fine:
image

this will however spawn another process that has it wrong:

image

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Jul 7, 2025

And what you did? Which process you've spawned and how?

@antirotor
Copy link
Member

And what you did? Which process you've spawned and how?
This happens when you run

.\manage.ps1 run --project TestProejct

First, it will print correct bundles, than it opens new terminal window and print the other output

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is what we found out during testing:

  • whenever there is process that cannot be run in the context of project bundle, it should state so (log some message) before running another process in studio bundle context
  • web actions are not respecting project bundle settings (tray publisher)
  • when you run ayon_console with project bundle set, any new project will use just ayon process (so new console window won't open)

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Jul 21, 2025

whenever there is process that cannot be run in the context of project bundle, it should state so (log some message) before running another process in studio bundle context

Added log to tray logic causing this.

web actions are not respecting project bundle settings (tray publisher)

Should be fixed now.

when you run ayon_console with project bundle set, any new project will use just ayon process (so new console window won't open)

I think it is not related to this PR. There is upcoming PR here that might fix it, but I'd rather test it together when this is merged.

@iLLiCiTiT iLLiCiTiT requested a review from antirotor July 21, 2025 17:28
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it works!

return time.time() > self._outdate_time


def _get_addons_settings(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could use typehints 🤖

@ynbot ynbot moved this to Review In Progress in PR reviewing Jul 30, 2025
@iLLiCiTiT iLLiCiTiT merged commit 912f920 into develop Aug 14, 2025
2 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/per-project-bundle branch August 14, 2025 14:21
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in PR reviewing Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump minor size/S sponsored This is directly sponsored by a client or community member type: feature Adding something new and exciting to the product

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants