implement {colorspace} key for burnins
#1373
Draft
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
resolve #1372
Additional Info
The
{colorspace}in this context is resolved to the target colorspace.We may need to add support for the source colorspace which may need another PR to add the source colorspace to the collected data as the colorspace data that is available atm are
{ "colorspace": "Output - Rec.709", "config": { "path": "E:\\Ynput\\ayon-ocio\\client\\ayon_ocio\\configs\\OpenColorIOConfigs\\aces_1.2\\config.ocio", "template": "{BUILTIN_OCIO_ROOT}/aces_1.2/config.ocio" } }Also, the source colorspace key may not be needed as this PR #1268 suggests
colorspacekey for source colorspace andtargetOCIOColorspacekey for the target colorspace if I'm not mistaken.Demo
Testing notes:
{colorspace}should work in burnin settings.