Loader/Browser Thumbnail improvements: Double-Click to Open & video representation thumbnail playback #1515
Conversation
… LoaderWindow - Implemented video representation path retrieval in LoaderWindow. - Enhanced ThumbnailPainterWidget to detect video files and manage playback. - Added functionality to extract the first frame from videos for thumbnail previews. - Updated mouse event handling to toggle video playback on single click.
|
This sounds neat! Any chance you can attach some previews of what it looks like in action? Side note: Your code has some style changes that I'm sure are from some linter to doing it, but they don't adhere to AYON's code style if I'm correctly looking at it. Any chance you can keep the 'style changes' out of the PR? |
BigRoy
added
community
2025-10-30.21-29-47.mp4There are few things to consider,
|
|
Thanks @MustafaJafar for the video and feedback. These are definitely important issues to fix before this can get merged. Odd that the single-click play isn't working but I will try and recreate and get back to you. Cheers! |
|
Upon reviewing the "thumbnail lag", video overlay and thumbnail type issues aside, there is a complication with how this was designed before my pull request: |
…nail handling in LoaderWindow - Added a method to select the latest published item in the ProductsWidget. - Enabled automatic selection of the first item when no versions or folders are selected in LoaderWindow. - Improved thumbnail management by clearing thumbnails when no entities are selected or when clearing current thumbnails.
…s://github.com/FuzzkingCool/ayon-core into loader_thumbnail_open_or_play_video
| self._selected_version_ids = set(event["version_ids"]) | ||
| self._update_thumbnails() | ||
|
|
||
| def _get_video_representation_path(self, project_name, version_ids): |
There was a problem hiding this comment.
Please, no pipeline or ayon api usage in UI. All backend to do stuff should be moved to controller (and models).
| and not self._selected_folder_ids | ||
| ): | ||
| self._auto_select_first_item = False | ||
| self._products_widget.select_latest_item() |
There was a problem hiding this comment.
So if I select different version and then hit refresh, it will also change what I had selected in browser?
| self._auto_select_first_item = False | ||
| self._products_widget.select_latest_item() | ||
|
|
||
| def _on_thumbnail_double_clicked(self, thumbnail_path): |
| """ | ||
|
|
||
| # Signal emitted when thumbnail is double-clicked | ||
| thumbnail_double_clicked = QtCore.Signal(str) # Emits the thumbnail path |
There was a problem hiding this comment.
Doubled information
| thumbnail_double_clicked = QtCore.Signal(str) # Emits the thumbnail path | |
| thumbnail_double_clicked = QtCore.Signal(str) |
| self._on_media_status_changed | ||
| ) | ||
| except (AttributeError, TypeError): | ||
| # Qt5 fallback |
There was a problem hiding this comment.
What exactly is different? And why it crashes? The only difference I see is QMediaPlayer initialization (one line) but whole logic is duplicated. If it's because VideoSurface should be used then do
if hasattr(QtMultimedia.QMediaPlayer, "VideoSurface")"
self._media_player = QtMultimedia.QMediaPlayer(
self, QtMultimedia.QMediaPlayer.VideoSurface
)
else:
self._media_player = QtMultimedia.QMediaPlayer(self)
| try: | ||
| end_of_media = QtMultimedia.QMediaPlayer.MediaStatus.EndOfMedia | ||
| except AttributeError: | ||
| # Qt5 uses QMediaPlayer.EndOfMedia | ||
| end_of_media = QtMultimedia.QMediaPlayer.EndOfMedia |
There was a problem hiding this comment.
| try: | |
| end_of_media = QtMultimedia.QMediaPlayer.MediaStatus.EndOfMedia | |
| except AttributeError: | |
| # Qt5 uses QMediaPlayer.EndOfMedia | |
| end_of_media = QtMultimedia.QMediaPlayer.EndOfMedia | |
| # Qt5 uses QMediaPlayer.EndOfMedia | |
| end_of_media = getattr( | |
| QtMultimedia.QMediaPlayer, | |
| "EndOfMedia", | |
| QtMultimedia.QMediaPlayer.MediaStatus.EndOfMedia | |
| ) |
| if not filepath: | ||
| return False | ||
| basename = os.path.basename(filepath).lower() | ||
| # Check for h264_* naming convention |
There was a problem hiding this comment.
Why? There is not a convention.
| if "h264_" in basename or "h264" in basename: | ||
| return True | ||
| # Check for common video extensions | ||
| video_exts = (".mp4", ".mov", ".avi", ".mkv", ".webm", ".m4v") |
There was a problem hiding this comment.
Should be constant and can be set.
| video_exts = (".mp4", ".mov", ".avi", ".mkv", ".webm", ".m4v") | |
| video_exts = {".mp4", ".mov", ".avi", ".mkv", ".webm", ".m4v"} |
| return True | ||
| # Check for common video extensions | ||
| video_exts = (".mp4", ".mov", ".avi", ".mkv", ".webm", ".m4v") | ||
| return any(filepath.lower().endswith(ext) for ext in video_exts) |
There was a problem hiding this comment.
| return any(filepath.lower().endswith(ext) for ext in video_exts) | |
| ext = os.path.splitext(filpath)[1].lower() | |
| return ext in video_exts |
| video_exts = (".mp4", ".mov", ".avi", ".mkv", ".webm", ".m4v") | ||
| return any(filepath.lower().endswith(ext) for ext in video_exts) | ||
|
|
||
| def _extract_first_frame(self, video_path): |
There was a problem hiding this comment.
Eh, why?
Running ffmpeg on each selection change can be very heavy... And when are the temp files cleaned up?
(Should be in controller.)
| from .lib import paint_image_with_color | ||
|
|
||
|
|
||
| class ThumbnailPainterWidget(QtWidgets.QWidget): |
There was a problem hiding this comment.
With changes made in this PR the widget is loader tool specific and should be moved there.
|
I might be wrong, but I believe most of studios don't integrate reviewables as representation anymore as they're uploaded to AYON server as activity. The code is very dirty and requires changes to be approved (at least for me), but the question is if this approach is the way to go with video player feature. |
5 participants
This pull request enhances the thumbnail preview functionality in the Loader tool, introducing support for video thumbnails (particularly h264_* and other common video formats) and enabling video playback directly within the thumbnail widget. It also allows users to open thumbnails with the system's default viewer via double-click.
Video thumbnail and playback support:
client/ayon_core/tools/loader/ui/window.py,client/ayon_core/tools/utils/thumbnail_paint_widget.py) [1] [2] [3]client/ayon_core/tools/utils/thumbnail_paint_widget.py)User interaction improvements:
client/ayon_core/tools/loader/ui/window.py,client/ayon_core/tools/utils/thumbnail_paint_widget.py) [1] [2] [3]UI and code refactoring:
client/ayon_core/tools/utils/thumbnail_paint_widget.py) [1] [2] [3] [4] [5] [6]