-
Notifications
You must be signed in to change notification settings - Fork 67
ExtractOIIOTranscode: Add filtering by representation name #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jakubjezek001
wants to merge
6
commits into
develop
Choose a base branch
from
enhancement/oiio-transcode-representation-filtering
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ExtractOIIOTranscode: Add filtering by representation name #1618
jakubjezek001
wants to merge
6
commits into
develop
from
enhancement/oiio-transcode-representation-filtering
+25
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that instances with added review representations are properly tagged with the "review" family for downstream processing.
Adds support for filtering which representations to transcode based on regex patterns. The profile now accepts a list of representation name patterns, and only matching representations will be processed. If no patterns are specified, all representations are processed.
iLLiCiTiT
reviewed
Dec 18, 2025
iLLiCiTiT
reviewed
Dec 18, 2025
iLLiCiTiT
reviewed
Dec 18, 2025
BigRoy
reviewed
Dec 18, 2025
Remove unnecessary list construction and use early returns instead of collecting boolean results in a list.
ExtractOIIOTranscodeProfileModel
iLLiCiTiT
reviewed
Jan 5, 2026
| return True | ||
|
|
||
| return False | ||
|
|
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size/XS
sponsored
This is directly sponsored by a client or community member
type: enhancement
Improvement of existing functionality or minor addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This enhancement adds representation filtering capability to ExtractOIIOTranscode, enabling selective processing of representations based on name patterns. The feature addresses the need for more granular control over which representations undergo color transcoding operations.
The implementation introduces a new
representationsfield in profile settings, allowing users to specify regex patterns that determine which representations should be processed. When patterns are defined, only matching representations are transcoded; an empty list processes all representations, maintaining backward compatibility with existing workflows.Additionally, the system now automatically adds the "review" family to instances when review outputs are generated, ensuring proper downstream processing of transcoded review files. This resolves workflow gaps where review files were created but not properly tagged for review systems.
Additional info
Key technical changes:
representationslist field toExtractOIIOTranscodeProfileModelin server settings_repre_is_valid()method to accept profile parameter and evaluate representation name patterns using regex matchingPattern matching behavior:
Testing notes:
["beauty", "render.*"])representationslist to confirm all representations are processed (backward compatibility)