Skip to content

Conversation

@martastain
Copy link
Member

@martastain martastain commented Jun 12, 2025

This pull request introduces a visual enhancement to the InboxMessage component by adding a new project-name element alongside the existing title element and styling it for improved readability and consistency. The changes include updates to the JSX structure and corresponding CSS styles.

image

@martastain martastain self-assigned this Jun 12, 2025
@martastain martastain added the type: enhancement Improvement of existing functionality or minor addition label Jun 12, 2025
@martastain martastain linked an issue Jun 12, 2025 that may be closed by this pull request
@Innders Innders self-requested a review June 16, 2025 07:40
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea and the project name should definitely be included.

When testing on my smaller screen this new column was causing some issues as it takes up a lot of room.

The project name is more secondary information and so I think we can afford to place it somewhere else that's less space hogging.

What do you think about simply putting it at the end of the first column with the outline colour?

image
  1. It's more compact and takes up less horizontal space
  2. The slight text colour difference indicates it's secondary information whilst also making it easy to pick out.

@martastain
Copy link
Member Author

The project name is more secondary information and so I think we can afford to place it somewhere else that's less space hogging.

Idk... that way it would like american date formats. i'm not a UX expert, but from the semantic point of view, i'd respect the cardinality of the information. and big endian > little endian, because it's big :)

@BigRoy
Copy link
Contributor

BigRoy commented Jun 17, 2025

Idk... that way it would like american date formats. i'm not a UX expert, but from the semantic point of view, i'd respect the cardinality of the information. and big endian > little endian, because it's big :)

I actually agree here - project name, even though likely repetitive in the inbox seems like the initial thing to "filter by" when going over my notifications.

@Innders
Copy link
Member

Innders commented Jun 17, 2025

How about something like this?

image

@BigRoy
Copy link
Contributor

BigRoy commented Jun 17, 2025

How about something like this?

image

Hard to tell without seeing them in a bulk list of them... but my gut feeling is saying that in this case I may like your previous version more without the vertical stacking of the data.

@Innders
Copy link
Member

Innders commented Jun 18, 2025

Hard to tell without seeing them in a bulk list of them

image

@BigRoy
Copy link
Contributor

BigRoy commented Jun 18, 2025

Quite busy for my taste for an 'inbox' which should really be a quick view at latest messages. I like the flatter design matches more with what I usually see myself in an inbox, but may be a very personal opinion.

@martastain
Copy link
Member Author

I like that actually. It's busy, but i am able to filter it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can project name/code in the Inbox messages

4 participants