-
Notifications
You must be signed in to change notification settings - Fork 36
Details panel: Dropdown menu for entity actions #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
87fc532 to
822fec3
Compare
|
It works, but i wouldn't merge it RN because of the mentioned duplicates. not just PIP icon, but i don't think upload thumbnail/version should be at two different places. It's kinda confusing. Let's wait for @Innders |
|
@redmonkez12 please use https://github.com/ynput/ayon-frontend/blob/ae7b98bdfec9d38d74779729dcb0c9bb190055ce/src/components/Menu/MenuComponents/Menu.jsx dropdown menu we already have. Look at https://github.com/ynput/ayon-frontend/blob/ae7b98bdfec9d38d74779729dcb0c9bb190055ce/src/containers/header/AppHeader.jsx to see how it is implemented. |
Innders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
822fec3 to
c7ea313
Compare
Innders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it's looking good!
"Add to list" should show a sub menu of lists to add the entity to and the option to create a new list like in the context menu. I think the menu component supports sub menus but I haven't tried it in a while.
The "View Data" item should always be the last item and should have label "View data" only.
1db4201 to
14d687c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use
more_horizicon instead (sorry my bad). - When the menu is open keep the dropdown button highlighted.
- Dragging and dropping files to either upload a thumbnail or create a new version is broken. You should be able to drag and drop a file onto the header to do this.
- I can't seem to ever see the add to list item, is this supported?
661477c to
bf3bae6
Compare
bf3bae6 to
a2c5945
Compare
Innders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
89b20b2 to
d92d4d2
Compare
Innders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The menu goes off the screen. Although it is scrollable it's very weird. The menu itself should not go off the screen and should be a scrollable container itself.
Since opening this PR we have added list folders. This means we will need to add it here as well. (ayon.dev has some good examples of list folders on demo_Commercial)
- The add to list menu should create the same folder structure on the lists page and right click context menu. Make sure to use the icons in the submenu as well.
2b5bed7 to
a954ed1
Compare
f3691c3 to
1e6da3f
Compare
Innders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are so close! Unfortunately the sub-menus seem really buggy especially when they are multiple levels deep. Often it's near impossible to get to sub menu items.
I would suggest creating some more complex folder structures for lists to test properly.
Screen.Recording.2025-10-09.at.20.23.59.mov
1e6da3f to
e648e72
Compare
I added a similar approach that we have in primereact Screen.Recording.2025-10-13.at.6.17.43.mov |
Innders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0d184bc to
8e22b57
Compare
Innders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.








Description of changes
This pull request adds a dropdown menu to the details page. The dropdown menu contains five actions
Upload version and add to the list are displayed only when they are available
Update
Additional context