Skip to content

Conversation

@redmonkez12
Copy link
Contributor

@redmonkez12 redmonkez12 commented Aug 25, 2025

Description of changes

This pull request adds a dropdown menu to the details page. The dropdown menu contains five actions

  • Picture in picture
  • Upload thumbnail
  • Upload version
  • View details
  • Add to list

Upload version and add to the list are displayed only when they are available

Update

  • Renamed dropdown menu option to view data
  • Removed picture in picture
  • Removed thumbnail context menu
  • Used the menu component

Additional context

  • Do we want to display picture in picture icon when it's in the dropdown?
  • Do all pages with dropdown have all five actions or is it okay as we have it now
Screenshot 2025-08-28 at 7 37 07

@redmonkez12 redmonkez12 marked this pull request as draft August 25, 2025 09:35
@redmonkez12 redmonkez12 force-pushed the 1249-dropdown-actions branch 6 times, most recently from 87fc532 to 822fec3 Compare August 28, 2025 05:39
@redmonkez12 redmonkez12 self-assigned this Aug 28, 2025
@redmonkez12 redmonkez12 added the type: feature Adding something new and exciting to the product label Aug 28, 2025
@redmonkez12 redmonkez12 marked this pull request as ready for review August 28, 2025 05:42
@martastain
Copy link
Member

It works, but i wouldn't merge it RN because of the mentioned duplicates. not just PIP icon, but i don't think upload thumbnail/version should be at two different places. It's kinda confusing. Let's wait for @Innders

@Innders Innders requested review from Innders and removed request for filipvnencak September 1, 2025 07:25
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the current right click menu options on the thumbnail itself.
Image
  • Remove pip from top menu (still in dropdown menu)
Image
  • View details renamed to "View data"

@redmonkez12 redmonkez12 force-pushed the 1249-dropdown-actions branch from 822fec3 to c7ea313 Compare September 4, 2025 19:11
@redmonkez12 redmonkez12 requested a review from Innders September 5, 2025 09:43
@Innders Innders removed the request for review from martastain September 5, 2025 12:36
@Innders Innders linked an issue Sep 5, 2025 that may be closed by this pull request
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, it's looking good!

"Add to list" should show a sub menu of lists to add the entity to and the option to create a new list like in the context menu. I think the menu component supports sub menus but I haven't tried it in a while.

Image

The "View Data" item should always be the last item and should have label "View data" only.

@Innders Innders changed the title 1249 dropdown actions Details panel: Dropdown menu for entity actions Sep 5, 2025
@redmonkez12 redmonkez12 requested a review from Innders September 15, 2025 17:49
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use more_horiz icon instead (sorry my bad).
  • When the menu is open keep the dropdown button highlighted.
  • Dragging and dropping files to either upload a thumbnail or create a new version is broken. You should be able to drag and drop a file onto the header to do this.
  • I can't seem to ever see the add to list item, is this supported?

Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works great!

How hard is it to get the "add to list" on the overview page?

Image

@redmonkez12 redmonkez12 force-pushed the 1249-dropdown-actions branch 2 times, most recently from 89b20b2 to d92d4d2 Compare October 6, 2025 02:50
@redmonkez12
Copy link
Contributor Author

For this to be complete this really needs to have the "add to list" options everywhere, not just on some pages.

This means it needs to work on the overview page, the home page and any other page the details panel might appear on.

Fixed two issues when multiple dropdowns are opened

Screenshot 2025-10-06 at 5 41 37 Screenshot 2025-10-06 at 5 03 57

@redmonkez12 redmonkez12 requested a review from Innders October 6, 2025 03:46
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The menu goes off the screen. Although it is scrollable it's very weird. The menu itself should not go off the screen and should be a scrollable container itself.
Image

Since opening this PR we have added list folders. This means we will need to add it here as well. (ayon.dev has some good examples of list folders on demo_Commercial)

  • The add to list menu should create the same folder structure on the lists page and right click context menu. Make sure to use the icons in the submenu as well.
Image Image

@redmonkez12 redmonkez12 force-pushed the 1249-dropdown-actions branch from 2b5bed7 to a954ed1 Compare October 8, 2025 17:47
@redmonkez12 redmonkez12 requested a review from Innders October 9, 2025 12:09
@redmonkez12 redmonkez12 force-pushed the 1249-dropdown-actions branch from f3691c3 to 1e6da3f Compare October 9, 2025 12:11
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are so close! Unfortunately the sub-menus seem really buggy especially when they are multiple levels deep. Often it's near impossible to get to sub menu items.

I would suggest creating some more complex folder structures for lists to test properly.

Screen.Recording.2025-10-09.at.20.23.59.mov

@redmonkez12 redmonkez12 force-pushed the 1249-dropdown-actions branch from 1e6da3f to e648e72 Compare October 13, 2025 04:15
@redmonkez12
Copy link
Contributor Author

We are so close! Unfortunately the sub-menus seem really buggy especially when they are multiple levels deep. Often it's near impossible to get to sub menu items.

I would suggest creating some more complex folder structures for lists to test properly.
Screen.Recording.2025-10-09.at.20.23.59.mov

I added a similar approach that we have in primereact

Screen.Recording.2025-10-13.at.6.17.43.mov

@redmonkez12 redmonkez12 requested a review from Innders October 13, 2025 04:20
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you test this with enough folders then this breaks down pretty fast. You need to add far more folders and then sub-folders to test properly.

Image

It should work like the context menu. The sub menu it always in line with the parent menu.

Image

@redmonkez12 redmonkez12 requested a review from Innders October 24, 2025 12:32
@redmonkez12 redmonkez12 force-pushed the 1249-dropdown-actions branch from 0d184bc to 8e22b57 Compare October 24, 2025 12:35
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling completely different now?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Adding something new and exciting to the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Details Panel: Dropdown menu with actions

4 participants