Download: Set content size only once #295
Conversation
iLLiCiTiT
changed the title
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Bit confused by this change. So does this mean only the initial response contains the Content-length? Or is this just an 'optimization' at this point?
If it fails in the middle it continues where it ended, content size is already known. |
I don't really see how this influences it - and like you I'm unsure how to really test this easily. |
It doesn't influence it, the content size is already known. And |
ayon_api/server_api.py
Outdated
| if not content_size_set: | ||
| content_size_set = True | ||
| progress.set_content_size( | ||
| response.headers["Content-length"] | ||
| ) |
There was a problem hiding this comment.
Why not do if progress.get_content_size() is None: - instead of having a local variable here to maintain?
Changelog Description
Set content length only once. If download fails in the middle.
Testing notes:
Not sure how to test, it would have to fail in the middle of download.