Skip to content

Add timeline labels to chart x-axis and preserve commit hash in tooltips #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wojtekn wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −7
Open

Add timeline labels to chart x-axis and preserve commit hash in tooltips #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions pages/project/[[...slug]]/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import Layout from '../../../components/layout'
import { Chart as ChartJS, Tooltip, registerables } from 'chart.js'
import dynamic from 'next/dynamic'
import { useRouter } from 'next/router'
import { format } from 'date-fns'

ChartJS.register(...registerables)

Expand Down Expand Up @@ -109,21 +110,30 @@ function Metric({ metric, repository }) {
}

const { offsetLeft, offsetTop } = chart.canvas
const dataIndex = tooltip.dataPoints?.[0]?.dataIndex
const hash = perf?.[dataIndex]?.hash

setTooltipData({
isVisible: true,
left: offsetLeft + tooltip.caretX,
top: offsetTop + tooltip.caretY,
titleLines: tooltip.title || [],
bodyLines: tooltip.body.map(({ lines }) => lines)
bodyLines: tooltip.body.map(({ lines }) => lines),
hash: hash
})
}, [])
}, [perf])
const options = useMemo(
() => ({
responsive: true,
scales: {
x: {
display: false
display: true,
ticks: {
maxRotation: 45,
minRotation: 45,
autoSkip: true,
maxTicksLimit: 10
}
},
y: {
min: 0
Expand Down Expand Up @@ -156,7 +166,7 @@ function Metric({ metric, repository }) {
)
const data = useMemo(
() => ({
labels: perf?.map((p) => p.hash),
labels: perf?.map((p) => format(new Date(p.measured_at), 'MMM d, yyyy HH:mm')),
datasets: [
{
label: metric.name,
Expand Down Expand Up @@ -299,10 +309,20 @@ function GraphTooltip({ repository, tooltipData }) {
}}
>
<div style={{ color: '#fff', fontSize: '12px' }}>
{tooltipData.titleLines.map((title, i) => (
<a key={i} href={`${repository}/commit/${title}`} target='blank' style={{ display: 'inline-block' }}>
{title.slice(0, 7)}
{tooltipData.hash && (
<a
key='hash'
href={`${repository}/commit/${tooltipData.hash}`}
target='blank'
style={{ display: 'block', marginBottom: '4px' }}
>
{tooltipData.hash.slice(0, 7)}
</a>
)}
{tooltipData.titleLines.map((title, i) => (
<div key={i} style={{ marginBottom: '2px' }}>
{title}
</div>
))}
{tooltipData.bodyLines.map((line, i) => (
<div className='flex items-center' key={i}>
Expand Down