Update packages to newest versions #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix issues with CsvHelper 30.0.1
| } | ||
|
|
||
| Context = new CsvContext(this); | ||
| _leaveOpen = Configuration.LeaveOpen; |
There was a problem hiding this comment.
Removing this here, should result in this (and probably more) constructor(s) to have the option to set this directly instead.
| sheetName, new CsvConfiguration(culture) {LeaveOpen= leaveOpen}) | ||
| sheetName, new CsvConfiguration(culture)) | ||
| { | ||
| _leaveOpen = leaveOpen; |
There was a problem hiding this comment.
This constructor should just pass leaveOpen to the "master" constructor to be consistent
|
Can this please be merged? |
bsumter
approved these changes
Apr 6, 2023
GodzSky
approved these changes
May 16, 2023
GodzSky
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is