Skip to content

Pointer implementation of fusion #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
YangLiuWillow wants to merge 74 commits into
base: pointer_fusion
Choose a base branch
from
Open

Pointer implementation of fusion #22

YangLiuWillow wants to merge 74 commits into from

Conversation

@YangLiuWillow
Copy link
Collaborator

@YangLiuWillow YangLiuWillow commented Sep 11, 2024

  • This is the most updated fusion implementation with pointer passing
  • Currently, it runs about 10-20 times slower with RotatedPlanarCode, StandardXZZX, RotatedXZZX, etc.

杨柳 and others added 30 commits May 27, 2024 17:23
Testing for push github
35d2aae
copying dual_modual_parallel.rs from fusion blossom to mwpf
3920266
copying and modifying dual_module_parallel.rs, need to think over the…
b1ec1ac 
… pointers
modifying mwpm_solver to add SolverParallel, need to debug DualModule…
5ef3553 
…Impl in dual_module_parallel.rs
@YangLiuWillow
Merge branch 'yuewuo:main' into main
6a662a7
worked on dual_module_parallel.rs, decided to start from a clean code
e3a7531
reworked util.rs and dual_module.rs with ArcRwLock
c773155
worked on dual_module_parallel.rs
4065d31
worked on dual_module_parallel.rs , need to think over the Partition …
ade2a52 
…defined
consulted Yue on virtual_vertices, the mirrored_vertices are generate…
3d5fbb3 
…d independent of these virtual_vertices
make changes
c1ec2c7
modified dual_module_parallel.rs
c04b930
changed dual_module_paralle.rs
835aee5
modifying GroupMaxUpdateLength
85d8259
simple demo works
d678929
maintain the original version
4792c5f
last version of parallel, create a new branch to avoid using parallel
aafecf9
pointer with hashset
ac37f86
remove decoding_graph in suggestion
0fd398f
trying to fix the panic at relaxer_forest_require_multiple test
c9e58ba
fixing panic at relaxer_forest.rs
518e062
change to btreeset, panic resolved
45e96a0
random panic resolved, but resolve time extensively varies for seed 131
e321d31
implementing parallel for pointer version of dual_module_pq.rs
62f3c0e
trying to accommodate for vertices with discontinuous indices
ea1c20f
parallel implementation with continuous vertices
3849b56
fixed growing into other units, but now grows too much, assert fails
815d433
bug: final subgraph is wrong
6278c90
add get_vertex_neighbor() for EdgePtr, seem to solve the previous bug…
b1cadf1 
… of subgraph mismatch, but the original mwpf solver seems unstable
fixed modifying mirrored_vertices of vertex_ptr of different units, d…
e036bb1 
…ual_module_parallel.rs seems to run fine now, need further optimization using rayon and pointers
杨柳 and others added 30 commits August 27, 2024 17:57
generate primal_module_parallel.rs animation
db15979
thread_pool in parallel_solve_step_callback
8508eba
needs to fix split_num = 8 panic of growth larger than weight
cea0f2e
changed nm to 18 for circuit level noise
4ecb7cc
found a bug when there are multiple defect nodes on the boundary unit
863781f
trying to figure out bug on defect vertices on boundary unit
31435f5
reset the growth of edge_connected_to_boundary_vertex to be half of i…
a61cb2d 
…ts original weight, take the floor of sum_dual_variables()
added in separate and combine_again to make the fusion reversible
5a68b25
should compare the resolve time with serial implementation
689ba90
need more work to reduce resolve time
be55d6a
remove set growth during fusion
7704e39
test resolve time for primal_module_Serial
78a43ee
removed floor
4c3f8a3
remove floor for sum_dual_variables
a3e913f
turned off visualizer
03e559a
add unsafe pointers
271d37d
should focus on resolve time of circuit level noise
93801fd
maybe run flamegraph on circuit level noise test case
0c4f044
tried to add command line tool to mwpf
f2fab92
implemented some command line tool for parallel implementation
2942b07
added flamegraph
ec26c03
print model
b4b45ec
print model row col
4c8af3c
add timeout and fixed pointer hashing
34483c3
added unit_active and now parallel is faster than serial, but further…
2bf6b78 
… optimization is needed
need to fix memeory issue
99307f7
fixed circular reference in Dualmoduleparallelunitptr neighbors
4a504e7
need to add initialization of individual paralle unit
ecbec28
@YangLiuWillow
fuse and solve newly (additionally) added unit with original existing…
5f4e410 
… units, need to visualize the entire space-time chunks and check for accuracy
@YangLiuWillow
add lattice surgery
55b5759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YangLiuWillow @yuewuo