feat: Add comprehensive tests for parsing logic #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces new tests for the `internal/paramify` package, significantly increasing test coverage. New test suites were added for: - `ParsePackage`: Verifies package loading, including handling of non-existent directories, directories with no Go files, and files with syntax errors. - `ValuesOfType`: Ensures correct extraction of required and optional fields from structs, covering a wide variety of field types (primitives, pointers, structs, arrays, maps, interfaces, any) and `omitempty` tags. Enhancements were made to existing tests for: - `isPointer`: Added cases for arrays of pointers and maps with pointer values. - `isInterface`: Added cases for direct interface types and clarified behavior for aliases. - `isOmitEmpty`: Added cases for tags with multiple options and unrelated tags. During the process of adding these tests, the following improvements were also made to the source code: - Enhanced `isInterface` to correctly identify `*ast.InterfaceType` nodes. - Improved error reporting in `ParsePackage` for syntax errors and empty Go file scenarios. - Refined error messages in `ValuesOfType` for cases like nil package input or type not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces new tests for the
internal/paramifypackage, significantly increasing test coverage.New test suites were added for:
ParsePackage: Verifies package loading, including handling of non-existent directories, directories with no Go files, and files with syntax errors.ValuesOfType: Ensures correct extraction of required and optional fields from structs, covering a wide variety of field types (primitives, pointers, structs, arrays, maps, interfaces, any) andomitemptytags.Enhancements were made to existing tests for:
isPointer: Added cases for arrays of pointers and maps with pointer values.isInterface: Added cases for direct interface types and clarified behavior for aliases.isOmitEmpty: Added cases for tags with multiple options and unrelated tags.During the process of adding these tests, the following improvements were also made to the source code:
isInterfaceto correctly identify*ast.InterfaceTypenodes.ParsePackagefor syntax errors and empty Go file scenarios.ValuesOfTypefor cases like nil package input or type not found.Describe your PR and link to any relevant issues.