[ARGO-229] Replaces error log with event emission when not connected to redis #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niall3rs
force-pushed
the
ncolfer/emit-events-not-logging-error-for-reconnection
branch
from
6b42d31 to
3de9832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that
ioredisautomatically handles reconnection, we can gracefully reconnect e.g. when there is a Sentinel failover. There is no need to log an error when the client cannot reach Redis. Replacing the error log with an event emission, so the events can be consumed upstream and handled as required.Also includes a minor bump of
ioredisfrom4.14to4.16References
Risks