-
-
Notifications
You must be signed in to change notification settings - Fork 0
Local #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fix hardcoded 1024 token limit, allow selecting longer models via config - Persist selected model path in user's cache directory for reuse - Warn when no models available instead of failing - Improve error messages related to model selection
- Delay EOS token sampling until meaningful text is generated - Skip commit when diff is empty instead of failing - Handle initial commit case where no parent exists
Introduce a GitHub Actions workflow that builds release binaries for macOS (Intel & Apple Silicon), Linux (x86_64 & ARM64) and Windows. Update the release workflow to download those artifacts, compute SHA256 checksums, patch `git-ca.rb` with the new version and bottle checksums, and push the updated formula to the `homebrew-tap` repository. Refresh documentation (`CLAUDE.md`, `DEPLOY.md`, `HOMEBREW.md`, `README.md`) to describe the multi‑platform releases and Homebrew installation steps. Modify `git-ca.rb` to include a `bottle` block and install the pre‑built binary instead of building from source.
|
Summary of ChangesHello @zh30, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant architectural shift for the Git Commit Analyzer, migrating from an external Ollama dependency to a fully local Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a significant and impressive refactoring of the project. The move from an Ollama dependency to a self-contained binary using llama.cpp is a major architectural improvement that will greatly enhance the user experience. The accompanying updates to the documentation across all languages, the release process, and the Homebrew formula are thorough and well-executed. The new code is well-structured, with robust features like model auto-downloading, deterministic fallbacks, and a doctor command for diagnostics. I have a couple of minor suggestions to improve Conventional Commits compliance and for general cleanup, but overall this is excellent work.
| hf-hub = { version = "0.4.3", default-features = false, features = ["ureq", "native-tls"] } | ||
| rand = "0.9" | ||
|
|
||
| # Test comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| match lower.as_bytes().get(commit_type.len()) { | ||
| Some(b'(') | Some(b':') => true, | ||
| _ => false, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is_commit_subject (and parse_commit_subject which has similar logic) doesn't handle the ! indicator for breaking changes as specified by the Conventional Commits standard (e.g., feat!: ...). To fully support the spec, this should be recognized as a valid format.
| match lower.as_bytes().get(commit_type.len()) { | |
| Some(b'(') | Some(b':') => true, | |
| _ => false, | |
| } | |
| match lower.as_bytes().get(commit_type.len()) { | |
| Some(b'(') | Some(b':') | Some(b'!') => true, | |
| _ => false, | |
| } |
No description provided.