Some small improvements #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Always the first difference - the current behavior seems be jumping to the cursor position when the file was last opened for edition. Sometimes some differences are missed because the buffers open with only the last differences on the screen. * Move the cursor to the first difference - the current behavior seems to be leaving the cursor at the diff window. I've found that most of the time it is necessary to check the changes on many files, and using \dj and \dk leaves the cursor on diff window, so it is necessary to move back to the diff windows.
The current behavior uses `:bd` to close a diff window after it is displayed on the screen, which causes any other windows displaying that file to be closed. The option g:DirDiffBufferDelete allows to use `:q` instead. In this case the `:diffoff` is also necessary to avoid subsequent diffs to be displayed incorrectly.
plugin/DirDiff.vim
Outdated
There was a problem hiding this comment.
"If true, the buffer is deleted after being displayed in a diff"
Author
|
I've added one commit yesterday, but I'm not sure if github generates a message about it. |
Author
|
I didn't understand the use of s:DirDiffIsRunning, introduced by 363cd0f, but it is clearly buggy, as it makes impossible to update ('u') the diff list after changing the exclude pattern ('x'). It is unclear why the user should be prevented from using more than one DirDiff, as it works fine when you have each one on its own tabpage. |
|
Yeah I don't understand it either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some small improvements on that I made over the years, and finally I took the time to upload them.
I've sent some of them to the original author, but it seems he doesn't use the e-mail at vim.org anymore.