added esp8266 Arduino compatibility #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Your pixels library looks great so I decided to make it compatible with the esp8266 Arduino core. So I could use it in my projects.
here is the core library if you are not familiar:
https://github.com/esp8266/Arduino
I only have an ILI9341 screen so I only changed that device file, however the changes should work if applied to the other screens. The changes work for both the sw SPI and the hw SPI.
hwSPI can run through the whole PixelsTest sketch however it does hang on the antialias drawLines grid for some reason. (SPI too slow?) If I comment that out it can make it through the rest of the sketch.
swSPI draws much faster and doesn't hang on the antialias drawLines gride. So surprisingly swSPI is better on the esp8266 then the hwSPI. Perhaps the esp8266 hwSPI core library needs more work?
If you like these changes you should submit your library to the esp8266 libraries wiki.