Update spec to json-schema passed #1
Conversation
2_eselect/eselect.yaml
Outdated
| moduleIdentifier: | ||
| moduleName: eselect | ||
| moduleVersion: 0.0.1 | ||
| namespace: test/abc |
There was a problem hiding this comment.
namespace is optional. Let's remove it from this yaml to test the case.
There was a problem hiding this comment.
OK. Please also help update the definition here: https://msdata.visualstudio.com/AzureML/_git/ModuleDocs?path=%2Fdocs%2Fdefinition-of-module-spec.md&_a=preview
| moduleName: Merge every n files together cdd3b0ba | ||
| version: 0.0.1 | ||
| moduleVersion: 0.0.1 | ||
| namespace: test/test |
There was a problem hiding this comment.
I don't think test/test is a valid namespace. The first section of namespace should be a domain name, such as example.com.
There was a problem hiding this comment.
What if an company or organization doesn't have a domain name?
There was a problem hiding this comment.
Maybe he or she could use github.com/name/ as the prefix of the domain name
There was a problem hiding this comment.
I'm not sure github.com is a good choice. Why the organization name needs to be a domain name?
There was a problem hiding this comment.
It seems that golang package name and docker image name are taking this manner. We want to follow this because it "looks modern"
| - inputPath: InputFolder with merged type | ||
| - inputPath: InputFolder with multiple simple types | ||
| - outputPath: OutputFolder with dict type | ||
| - outputPath: OutputFolder with simple type |
There was a problem hiding this comment.
Why do you have these diff in your PR? maybe need to rebase?
2 participants
No description provided.