[PWGLF] Fix filling of V0CoreMCLabel in symmetric mode #14301
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 32 errors, |
github-actions
bot
changed the title
romainschotter
requested review from
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
maciacco,
mpuccio,
skundu692 and
smaff92
as code owners
alibuild
approved these changes
Dec 20, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @romainschotter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug about the filling of
V0CoreMCLabels, when operating the strangeness builder in symmetric mode (eachV0Coresentry having a correspondingV0MCCoresentry, i.e. the two tables are joinable), leading to the access of the wrongV0MCCoresentry.This bug only occurs if one uses
V0CoreMCLabelsto access the V0 MC information (by de-referencingV0MCCores). The problem is not present if one joins theV0CoresandV0MCCorestables instead.Here is a comparison of the invariant mass distribution of K0s (requiring correct MC association) with and without this fix, compared to the reference (joining
V0CoresandV0MCCores, in which case the bug does not occur):FixV0CoreMCLabels.pdf
Thank you very much @amatyja for reporting this bug!
@ddobrigk for your information