Skip to content

[PWGLF] Fix filling of V0CoreMCLabel in symmetric mode #14301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romainschotter merged 1 commit into from
Dec 20, 2025
+1 −1
Merged

[PWGLF] Fix filling of V0CoreMCLabel in symmetric mode #14301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGLF/Utils/strangenessBuilderModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@
if (baseOpts.mc_findableMode.value == 1) {
LOGF(info, " ===> findable mode 1 is enabled: complement reco-ed with non-found findable");
}
if (baseOpts.mc_findableMode.value == 2) {

Check failure on line 656 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
LOGF(info, " ===> findable mode 2 is enabled: re-generate all findable from scratch");
}

Expand Down Expand Up @@ -852,7 +852,7 @@
} // end is_table<TMCCollisions>
} // end findable mode check

if (baseOpts.mc_findableMode.value < 2) {

Check failure on line 855 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
// keep all unless de-duplication active
ao2dV0toV0List.resize(v0s.size(), -1); // -1 means keep, -2 means do not keep

Expand Down Expand Up @@ -939,10 +939,10 @@
if (bestPointingAngleIndex == ic && baseOpts.deduplicationAlgorithm.value == 1) {
ao2dV0toV0List[v0tableGrouped[iV0].V0Ids[ic]] = -1; // keep best only
}
if (bestDCADaughtersIndex == ic && baseOpts.deduplicationAlgorithm.value == 2) {

Check failure on line 942 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
ao2dV0toV0List[v0tableGrouped[iV0].V0Ids[ic]] = -1; // keep best only
}
if (bestDCADaughtersIndex == ic && bestPointingAngleIndex == ic && baseOpts.deduplicationAlgorithm.value == 3) {

Check failure on line 945 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
ao2dV0toV0List[v0tableGrouped[iV0].V0Ids[ic]] = -1; // keep best only
}
}
Expand Down Expand Up @@ -1055,7 +1055,7 @@
}
}
// findable mode 2
if (baseOpts.mc_findableMode.value == 2) {

Check failure on line 1058 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
currentV0Entry.globalId = -1;
currentV0Entry.collisionId = bestCollisionArray[positiveTrackIndex.mcCollisionId];
currentV0Entry.posTrackId = positiveTrackIndex.globalId;
Expand Down Expand Up @@ -1102,7 +1102,7 @@

// Cascade part if cores are requested, skip otherwise
if (baseOpts.mEnabledTables[kStoredCascCores] || baseOpts.mEnabledTables[kStoredKFCascCores]) {
if (baseOpts.mc_findableMode.value < 2) {

Check failure on line 1105 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
// simple passthrough: copy existing cascades to build list
for (const auto& cascade : cascades) {
auto const& v0 = cascade.v0();
Expand Down Expand Up @@ -1228,7 +1228,7 @@

// findable mode 2: determine type based on cascade table,
// with type 1 being reserved to findable-but-not-found
if (baseOpts.mc_findableMode.value == 2) {

Check failure on line 1231 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
currentCascadeEntry.globalId = -1;
currentCascadeEntry.collisionId = bestCollisionArray[bachelorTrackIndex.mcCollisionId];
currentCascadeEntry.v0Id = v0i; // fill this in one go later
Expand Down Expand Up @@ -1305,7 +1305,7 @@
for (const auto& cascade : cascadeList) {
if (cascade.v0Id < 0)
continue;
if (v0Map[cascade.v0Id] == -2) {

Check failure on line 1308 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
v0sUsedInCascades++;
}
v0Map[cascade.v0Id] = -1; // marks used (but isn't the index of a properly built V0, which would be >= 0)
Expand All @@ -1318,7 +1318,7 @@
trackedCascadeCount = trackedCascades.size();
for (const auto& trackedCascade : trackedCascades) {
auto const& cascade = trackedCascade.cascade();
if (v0Map[ao2dV0toV0List[cascade.v0Id()]] == -2) {

Check failure on line 1321 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
v0sUsedInCascades++;
}
v0Map[ao2dV0toV0List[cascade.v0Id()]] = -1; // marks used (but isn't the index of a built V0, which would be >= 0)
Expand Down Expand Up @@ -1353,7 +1353,7 @@
continue;
}

if (!baseOpts.mEnabledTables[kV0CoresBase] && v0Map[iv0] == -2) {

Check failure on line 1356 in PWGLF/Utils/strangenessBuilderModule.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
// this v0 hasn't been used by cascades and we're not generating V0s, so skip it
products.v0dataLink(-1, -1);
continue;
Expand Down Expand Up @@ -1634,7 +1634,7 @@
// code that is agnostic with respect to the joinability of
// V0Cores and V0MCCores (always dereference -> safe)
if (baseOpts.mEnabledTables[kV0CoreMCLabels]) {
products.v0CoreMCLabels(iv0); // interlink index
products.v0CoreMCLabels(products.v0mccores.lastIndex()); // interlink index
histos.fill(HIST("hTableBuildingStatistics"), kV0CoreMCLabels);
}
}
Expand Down
Loading