Fix hive-less cluster deployments when using containerized development environment #4509
Conversation
aasserzo
requested review from
cadenmarchese,
jharrington22 and
yjst2012
as code owners
aasserzo
requested review from
hlipsig,
kimorris27,
mociarain,
pepedocs,
sankur-codes,
tiguelu,
tsatam and
wanghaoran1988
as code owners
mociarain
left a comment
mociarain
left a comment
There was a problem hiding this comment.
This looks great. I wonder should we have a link/reference to this from the 'prepare-your-dev-environment.md' to show it as an option. If I was onboarding, I could miss this easily and it's what I would choose
mociarain
left a comment
mociarain
left a comment
There was a problem hiding this comment.
I'm good with this but I think it's worth sharing wider for visibility
|
I think we need to make sure that folks using the Hive in dev can still use it for the moment, is there a way we can support both? |
@hawkowl yes! this setup always worked with hive just like the locally running RP. This PR fixes non-hive cluster creation. |
| ```bash | ||
| SECRET_SA_ACCOUNT_NAME=<secrets_storage_account_name> make secrets | ||
| # Replace <secrets_storage_account_name> with the actual storage account name | ||
| # Ensure the secrets are placed in the ./secrets directory |
There was a problem hiding this comment.
Could you please add here or in the makefile the secrets setup step?
It seems to me .2 should be . ./env
| > With the local binaries installed you can then refer to the [Getting Started](#getting-started) section below to obtain the source code before deploying a development RP. | ||
| > | ||
| > Instead of running `make runlocal-rp`, use `make run-rp` to run a containerized version of the application without requiring additional local binaries. | ||
| > With the above tools installed, follow the [Getting Started](#getting-started) section to clone the repository, then see [Containerized Development Environment](containerized-dev-environment.md) to run the RP. |
There was a problem hiding this comment.
redundant with line 36
Which issue this PR addresses:
Fixes failures to install test clusters without hive when running a containerized development RP.
What this PR does / why we need it:
When using a containerized RP to deploy a cluster, and running a non-hive deployment (local openshift installer container), the RP fails to connect to the hosts podman socket to create the openshift installer.
This PR makes sure the RP container starts with the necessary mounts and permissions to create said installer.
Test plan for issue:
Deploy a cluster against the containerized RP with hive env variables unset.
Is there any documentation that needs to be updated for this PR?
This PR also updates the necessary documentation to make sure users are running podman compose.
How do you know this will function as expected in production?
Not intended for use in production.