fix: Remove blocking wait for GCP VM deletion in progress_reporter #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The progress_reporter endpoint was timing out (502 errors) when tests completed because it synchronously waited for GCP VM deletion, which can take 60+ seconds. This exceeded nginx's default 60s proxy timeout. The fix makes VM deletion fire-and-forget: - Initiate deletion but don't block waiting for completion - The VM will be deleted eventually - we don't need confirmation - All critical work (test results, GitHub status) completes first - Added logging to track initiated deletions Investigation on production server showed: - 11% of webhook requests returned 502 errors (11 out of 100 today) - nginx error logs showed "upstream timed out" for /progress-reporter/ - Pattern: Test completion logs showed ~60-70s between "Test completed" and "Test <completed>" due to wait_for_operation blocking 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cfsmp3
requested review from
canihavesomecoffee and
thealphadollar
as code owners
Break long log line into two lines to comply with 120 char limit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
canihavesomecoffee
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/progress-reporter/endpoint that occurred when tests completedwait_for_operation()could block for 60+ seconds, exceeding nginx's 60s proxy timeoutInvestigation Findings
Analysis of production server (
ssh ccextractor) revealed:upstream timed out (110: Unknown error) while reading response headerwait_for_operationblockingExample from logs:
Corresponding app logs:
Changes
wait_for_operation()call afterdelete_instance()Test plan
test_progress_type_requestpassestest_progress_type_request_empty_tokenpasses🤖 Generated with Claude Code