Skip to content

fix: Remove blocking wait for GCP VM deletion in progress_reporter #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canihavesomecoffee merged 2 commits into from
Dec 29, 2025
Merged

fix: Remove blocking wait for GCP VM deletion in progress_reporter #989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
070311c
fix: Remove blocking wait for GCP VM deletion in progress_reporter
cfsmp3 Dec 29, 2025
1c281a5
style: Fix line too long in log message
cfsmp3 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions mod_ci/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1960,14 +1960,19 @@ def update_final_status():
log.error(f"Test {test_id}: Failed to update final GitHub status after retries: {e}")

if status in [TestStatus.completed, TestStatus.canceled]:
# Delete the current instance
# Delete the current instance (fire-and-forget)
# We intentionally don't wait for the deletion to complete because:
# 1. Waiting can take 60+ seconds, exceeding nginx/gunicorn timeouts (502 errors)
# 2. The deletion will complete eventually - we don't need confirmation
# 3. All important work (test results, GitHub status) is already done
from run import config
compute = get_compute_service_object()
zone = config.get('ZONE', '')
project = config.get('PROJECT_NAME', '')
vm_name = f"{test.platform.value}-{test.id}"
operation = delete_instance(compute, project, zone, vm_name)
wait_for_operation(compute, project, zone, operation['name'])
op_name = operation.get('name', 'unknown')
log.info(f"[Test: {test_id}] VM deletion initiated for {vm_name} (op: {op_name})")

# If status is complete, remove the GCP Instance entry
if status in [TestStatus.completed, TestStatus.canceled]:
Expand Down